Relatorio

Bug 57

classification
Title: Fixing bugs in reports with repeated columns
Type: behavior Severity: normal
Components: opendocument Versions:
process
Status: new Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: bell, ced
Priority: normal Keywords: patch

Created on 2019-12-29 20:25 by bell, last changed 2020-01-03 14:33 by bell.

Files
File name Uploaded Description Edit Remove
patch.diff bell, 2019-12-29 20:25
test1.ods bell, 2019-12-30 12:38
test2.ods bell, 2019-12-30 12:38
Messages
msg120 (view) Author: [hidden] (bell) Date: 2019-12-29 20:25
This patch fixes bugs that were discussed here:
https://discuss.tryton.org/t/strange-column-widths-in-report-with-repeated-columns
https://discuss.tryton.org/t/report-with-repeated-columns-and-spanned-cells-in-heading
We are using Tryton 5.2.8 and relatorio 0.9.0
So this is a patch for relatorio 0.9.0
msg121 (view) Author: [hidden] (ced) Date: 2019-12-29 21:17
Could you upload it on https://codereview.tryton.org/ and add a test case?
msg122 (view) Author: [hidden] (bell) Date: 2019-12-29 21:35
How can I do this on Windows system?
What do you mean by a test case?
msg123 (view) Author: [hidden] (ced) Date: 2019-12-29 21:45
Test case are added in https://hg.tryton.org/relatorio/file/tip/relatorio/tests/test_odt.py
For how unittest module works, see https://docs.python.org/3.5/library/unittest.html

We need to have a minimal and reproducible example of failure to ensure there is a bug and that the proposed patch fix it.
msg124 (view) Author: [hidden] (bell) Date: 2019-12-30 10:51
What about Windows system?
I have only Windows computers at home.
msg125 (view) Author: [hidden] (ced) Date: 2019-12-30 11:03
There is nothing special with Windows.
msg126 (view) Author: [hidden] (bell) Date: 2019-12-30 12:40
Unfortunately, I have no experience with version control systems.
So while I upload the first template (temp1.ods) from this topic:
https://discuss.tryton.org/t/strange-column-widths-in-report-with-repeated-columns
and the first template (temp2.ods) from this topic:
https://discuss.tryton.org/t/report-with-repeated-columns-and-spanned-cells-in-heading
msg127 (view) Author: [hidden] (bell) Date: 2020-01-03 14:33
I have uploaded the patch for the latest relatorio version:
https://codereview.tryton.org/286471002/
History
Date User Action Args
2020-01-03 14:33:44bellsetmessages: + msg127
2019-12-30 12:40:45bellsetmessages: + msg126
2019-12-30 12:38:39bellsetfiles: + test2.ods
2019-12-30 12:38:26bellsetfiles: + test1.ods
2019-12-30 11:03:13cedsetmessages: + msg125
2019-12-30 10:51:50bellsetmessages: + msg124
2019-12-29 21:45:42cedsetmessages: + msg123
2019-12-29 21:35:01bellsetmessages: + msg122
2019-12-29 21:17:03cedsetpriority: urgent -> normal
type: crash -> behavior
messages: + msg121
severity: urgent -> normal
nosy: + ced
2019-12-29 20:25:54bellcreate